Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41026: Add PathLike object support to Mailbox constructor #20990

Closed
wants to merge 3 commits into from
Closed

bpo-41026: Add PathLike object support to Mailbox constructor #20990

wants to merge 3 commits into from

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Jun 19, 2020

@loz-hurst
Copy link

loz-hurst commented Jun 22, 2020

Hi,

I'm still trying to get my CLA sorted out (I signed it last week but I've been told they cannot find my BPO username despite it being correct on the CLA and BPO). Until this gets sorted out, I don't think you can merge this PR since you have copied and pasted my work (#20976, 793ad9a "Copy blurb and docs from @loz-hurst" - copying my work and removing me from the ACKS is both rude and plagiarism (since the commit message will get squashed when merged, losing all attribution of my contribution).

In short: This PR contains work that has not been contributed under the CLA yet.

Laurence

@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Jun 22, 2020

I closed this PR. Don’t worry. I never thought about squashing. It was my intention to hurt you. Since you said there is a lot of work to do in the comments , I thought I could do it.

@loz-hurst
Copy link

loz-hurst commented Jun 24, 2020

That's a shame, yours was more comprehensive than mine. I was only objecting to you copy and pasting parts of my work and removing the attribution of the work.

You do need to be careful about copying work that's not been submitted with a valid CLA and submitting it under your name which does, it could get Python into legal hot-water if it got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants