Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise phrasing points to index, not value #1769

Closed
PrettyFloralBonnet opened this issue Feb 24, 2020 · 6 comments
Closed

Exercise phrasing points to index, not value #1769

PrettyFloralBonnet opened this issue Feb 24, 2020 · 6 comments

Comments

@PrettyFloralBonnet
Copy link

@PrettyFloralBonnet PrettyFloralBonnet commented Feb 24, 2020

In https://javascript.info/array-methods#filter-range, I would suggest saying "...looks for elements with values higher or equal to a and lower or equal to b" rather than the current "...looks for elements between a and b".

Right now it sounds like "between" is referring to indices. The solution I wrote initially looked like this:

let filterRange = (arr, a, b) => {
    if (b > arr.length) return arr.slice(a);
    else return arr.slice(a, b);
};
@iliakan
Copy link
Member

@iliakan iliakan commented Feb 25, 2020

Make a PR please?

dorelljames added a commit to dorelljames/en.javascript.info that referenced this issue Oct 12, 2020
Updated based on suggestion on issue javascript-tutorial#1769
dorelljames added a commit to dorelljames/en.javascript.info that referenced this issue Oct 12, 2020
Updated based on suggestion on issue javascript-tutorial#1769
@dorelljames
Copy link
Contributor

@dorelljames dorelljames commented Oct 12, 2020

@iliakan I created a pull request #2194 for this very old issue. Thanks

@iliakan
Copy link
Member

@iliakan iliakan commented Oct 12, 2020

Thanks =)

@iliakan iliakan closed this Oct 12, 2020
@PrettyFloralBonnet
Copy link
Author

@PrettyFloralBonnet PrettyFloralBonnet commented Oct 12, 2020

Thank you. Sorry for not coming through with the PR back then, I was meaning to but never got around to it.

@dorelljames
Copy link
Contributor

@dorelljames dorelljames commented Oct 12, 2020

I'm sorry if I took it to myself @PrettyFloralBonnet. Thank you for understanding.

@PrettyFloralBonnet
Copy link
Author

@PrettyFloralBonnet PrettyFloralBonnet commented Oct 12, 2020

No worries @dorelljames , I'm grateful you picked it up ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.