Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update article.md #1738

Merged
merged 1 commit into from Sep 5, 2020
Merged

Update article.md #1738

merged 1 commit into from Sep 5, 2020

Conversation

@paroche
Copy link
Collaborator

@paroche paroche commented Feb 7, 2020

My proposed change may not be right, but "make a request to URL" was unclear, and it's fetch that's used below to make the request. If 'request to URL' has some special meaning, and is what you want to say, maybe some rephrasing is still in order.

My proposed change may not be right, but "make a request to URL" was unclear, and it's `fetch` that's used below to make the request. If 'request to URL' has some special meaning and is what you want to say, maybe some rephrasing is in order.
@iliakan iliakan merged commit 94279ab into master Sep 5, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@iliakan
Copy link
Member

@iliakan iliakan commented Sep 5, 2020

Sorry for the delay.

@paroche
Copy link
Collaborator Author

@paroche paroche commented Sep 5, 2020

Oh yeah, I remember that one, though I had kind of stopped wondering about it 😓.

But all's well that ends well, and all that. 😌

@paroche paroche deleted the paroche-patch-18 branch Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.