Skip to content

/ material.angular.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set scale on container #802

Merged
merged 2 commits into from Jun 29, 2020
Merged

set scale on container #802

merged 2 commits into from Jun 29, 2020

Conversation

@annieyw
Copy link
Collaborator

@annieyw annieyw commented Jun 25, 2020 •
edited

  • scale style wasn't setting properly after adding new scene-content-container div.
  • scale for divider scene was overridden at some point
  • typo in ripple
@annieyw annieyw requested review from atscott and mmalerba Jun 25, 2020
@googlebot googlebot added the cla: yes label Jun 25, 2020
@annieyw
fix scale
Loading status checks…
b323791
@annieyw annieyw force-pushed the annieyw:scale branch from 643ac87 to b323791 Jun 25, 2020
@mmalerba
Copy link
Collaborator

@mmalerba mmalerba commented Jun 25, 2020

do the screenshots need to be updated or there was no change?
@annieyw
new screenshots
Loading status checks…
005058e
@annieyw
Copy link
Collaborator Author

@annieyw annieyw commented Jun 25, 2020

Some of the screenshots were never checked in/didn't have the final screenshot checked in so I added them.
@mmalerba
mmalerba approved these changes Jun 29, 2020
View changes
Copy link
Collaborator

@mmalerba mmalerba left a comment

LGTM
@mmalerba mmalerba merged commit 2b0f9ea into angular:master Jun 29, 2020
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba

@atscott atscott

Assignees
No one assigned
Labels
cla: yes pr: lgtm pr: merge ready
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@annieyw @mmalerba @googlebot
You can’t perform that action at this time.