Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse vector #2173

Open
wants to merge 6 commits into
base: master
from
Open

sparse vector #2173

wants to merge 6 commits into from

Conversation

@shotanozadze
Copy link

shotanozadze commented Jul 4, 2020 •
edited

Describe your change:

Sparse Vector Implementation

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@shotanozadze
sparse vector
Loading status checks…
bed2e10
@TravisBuddy
Copy link

TravisBuddy commented Jul 4, 2020

Hey @shotanozadze,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 42553e70-be2d-11ea-a595-8f8781864445
@shotanozadze
upd
Loading status checks…
37e5f30
@TravisBuddy
Copy link

TravisBuddy commented Jul 4, 2020

Hey @shotanozadze,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6245adb0-be31-11ea-a595-8f8781864445
@shotanozadze
Copy link
Author

shotanozadze commented Jul 4, 2020

The command "flake8 --ignore=E203,W503 --max-complexity=25 --max-line-length=88 --statistics --count ." failed and exited with 1 during .

How can I solve this problem?
@cclauss
Copy link
Member

cclauss commented Jul 4, 2020 •
edited

Please read contributing.md because this code will not be merged without type hints and doctests.

https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md
Maybe run flake8 on your code to find out.

flake8 --ignore=E203,W503 --max-complexity=25 --max-line-length=88 --statistics --count .

./data_structures/sparse_vector/sparse_vector.py:1:1: F401 'fractions.Fraction' imported but unused
./data_structures/sparse_vector/sparse_vector.py:2:1: E302 expected 2 blank lines, found 0
./data_structures/sparse_vector/sparse_vector.py:8:37: W291 trailing whitespace
./data_structures/sparse_vector/sparse_vector.py:15:1: W293 blank line contains whitespace
./data_structures/sparse_vector/sparse_vector.py:23:40: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
@cclauss
cclauss requested changes Jul 4, 2020
View changes
Copy link
Member

cclauss left a comment

We don’t need a directory that only contains a single file.
@shotanozadze
tests and hints added
Loading status checks…
12bbd56
@TravisBuddy
Copy link

TravisBuddy commented Jul 5, 2020

Hey @shotanozadze,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 98392840-bea7-11ea-b6c3-5fc2c9c22d2c
@shotanozadze
upd
Loading status checks…
fa2db0b
@TravisBuddy
Copy link

TravisBuddy commented Jul 5, 2020

Hey @shotanozadze,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c1bb9cf0-bea9-11ea-b6c3-5fc2c9c22d2c
shotanozadze added 2 commits Jul 5, 2020
@shotanozadze
removed hints because of invalid syntax
Loading status checks…
cf1ec75
@shotanozadze
upd
Loading status checks…
9c43068
@TravisBuddy
Copy link

TravisBuddy commented Jul 5, 2020

Hey @shotanozadze,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ca26a730-beaa-11ea-b6c3-5fc2c9c22d2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Tests are needed Type hints needs automated tests are failing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@shotanozadze @TravisBuddy @cclauss
You can’t perform that action at this time.