Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Travis CI: Lower flake8 max-complexity to 15 #2139

Draft
wants to merge 4 commits into
base: master
from
Draft

WIP: Travis CI: Lower flake8 max-complexity to 15 #2139

wants to merge 4 commits into from

Conversation

@cclauss
Copy link
Member

cclauss commented Jun 21, 2020

Work In Progress Draft: Do not merge if test are not passing!!

Related to #2128, find all files that contain algorithms with > 15% McCabe complexity.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss and others added 2 commits Jun 21, 2020
@cclauss
WIP: Travis CI: Lower flake8 max-complexity to 15
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d02d7a0 
Work In Progress Draft: Do not merge if test are not passing!!

Related to #2128, find all files that contain algorithms with > 15% McCabe complexity.
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
b6799a2
@cclauss cclauss self-assigned this Jun 21, 2020
@TravisBuddy
Copy link

TravisBuddy commented Jun 21, 2020

Hey @cclauss,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2d639900-b37c-11ea-9aed-1d08be4b11c7
@itsvinayak itsvinayak mentioned this pull request Jun 21, 2020
Open
3 of 13 tasks complete
cclauss and others added 2 commits Jun 22, 2020
@cclauss
Retest
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a83e4f
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
9d47536
@TravisBuddy
Copy link

TravisBuddy commented Jun 22, 2020

Hey @cclauss,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 981d8b90-b483-11ea-bd89-f57d85bb28d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cclauss cclauss

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cclauss @TravisBuddy
You can’t perform that action at this time.