Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A .py file to covert a base to any new base(2-18) #1998

Open
wants to merge 3 commits into
base: master
from
Open

A .py file to covert a base to any new base(2-18) #1998

wants to merge 3 commits into from

Conversation

@sarcastic-verma
Copy link
Contributor

sarcastic-verma commented May 18, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@sarcastic-verma
A .py file to covert a base to any new base(2-18)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f047fb2
@cclauss
cclauss reviewed May 18, 2020
View changes
conversions/base_changer.py Outdated
@@ -0,0 +1,104 @@
num = input("Enter the number ").strip()

This comment has been minimized.

Sign in to view
Copy link
@cclauss

cclauss May 18, 2020 •
edited

Member

This line will halt our automated tests. It should be indented under
https://docs.python.org/3/library/__main__.html

This comment has been minimized.

Sign in to view
Copy link
@sarcastic-verma

sarcastic-verma May 18, 2020

Author Contributor

Added main
@sarcastic-verma
Update base_changer.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9c8b153
@sarcastic-verma
Added type-hints.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c1a7741
@stale
Copy link

stale bot commented Jun 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the wontfix label Jun 17, 2020
@cclauss
Copy link
Member

cclauss commented Jun 17, 2020 •
edited

Is this algorithm in some way better than
https://github.com/TheAlgorithms/Python/blob/master/conversions/decimal_to_any.py ?

Tests are failing at https://travis-ci.com/github/TheAlgorithms/Python/builds/166681964#L368
@stale stale bot removed the wontfix label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
automated tests are failing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sarcastic-verma @cclauss
You can’t perform that action at this time.