Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41292: Windows FAQ dead link fixed #21463

Merged
merged 1 commit into from Oct 19, 2020
Merged

Conversation

stardust85
Copy link
Contributor

@stardust85 stardust85 commented Jul 13, 2020

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jul 13, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@stardust85

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

eamanu
eamanu approved these changes Jul 14, 2020
Copy link
Contributor

@eamanu eamanu left a comment

Good catch!

eamanu
eamanu approved these changes Jul 14, 2020
@stardust85
Copy link
Contributor Author

stardust85 commented Jul 14, 2020

CLA signed (https://bugs.python.org/user29880) :) Should I add something to Misc/NEWS.d/next/? Is there a documentation how to do so? Or should I just simply get some inspiration from other changelog records?

@stardust85
Copy link
Contributor Author

stardust85 commented Aug 10, 2020

Hello, any update here?

@zooba zooba merged commit 33242a9 into python:master Oct 19, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2020

Thanks @stardust85 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@zooba
Copy link
Member

zooba commented Oct 19, 2020

Thanks for the PR, and sorry for taking our time getting to it!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
)

(cherry picked from commit 33242a9)

Co-authored-by: Michel Samia <m.samia@seznam.cz>
@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2020

GH-22788 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
)

(cherry picked from commit 33242a9)

Co-authored-by: Michel Samia <m.samia@seznam.cz>
@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2020

GH-22789 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 19, 2020
(cherry picked from commit 33242a9)

Co-authored-by: Michel Samia <m.samia@seznam.cz>
miss-islington added a commit that referenced this pull request Oct 19, 2020
(cherry picked from commit 33242a9)

Co-authored-by: Michel Samia <m.samia@seznam.cz>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir OS-windows skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants