Skip to content

Remove unnecessary spaces in code blocks in urllib.parse.rst #21500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2020
Merged

Remove unnecessary spaces in code blocks in urllib.parse.rst #21500

merged 1 commit into from
Jul 16, 2020

Conversation

chrisyeh96
Copy link
Contributor

@chrisyeh96 chrisyeh96 commented Jul 15, 2020 •
edited by miss-islington
Loading

This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella

@chrisyeh96
Remove unnecessary spaces in code blocks in urllib.parse.rst
b9bdb01 
This should also fix the syntax highlighting for these code blocks
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 15, 2020
csabella
csabella approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for submitting a patch for this. 🎉

@miss-islington miss-islington merged commit 5e5c0f9 into python:master Jul 16, 2020
@miss-islington
Copy link
Contributor

Thanks @chrisyeh96 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @chrisyeh96, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5e5c0f98667c9280c6d27b3db98a6cad2cc89077 3.9

@miss-islington miss-islington self-assigned this Jul 16, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2020
@chrisyeh96 @miss-islington
Remove unnecessary spaces in code blocks in urllib.parse.rst (pythonG…
e119f14 
…H-21500)

This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella
(cherry picked from commit 5e5c0f9)

Co-authored-by: Christopher Yeh <chrisyeh96@users.noreply.github.com>
@bedevere-bot
Copy link

GH-21505 is a backport of this pull request to the 3.8 branch.

@csabella csabella added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Jul 16, 2020
@miss-islington
Copy link
Contributor

Thanks @chrisyeh96 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2020
@chrisyeh96 @miss-islington
Remove unnecessary spaces in code blocks in urllib.parse.rst (pythonG…
5ca3648 
…H-21500)

This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella
(cherry picked from commit 5e5c0f9)

Co-authored-by: Christopher Yeh <chrisyeh96@users.noreply.github.com>
@bedevere-bot
Copy link

GH-21506 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 16, 2020
miss-islington added a commit that referenced this pull request Jul 16, 2020
@miss-islington @chrisyeh96
Remove unnecessary spaces in code blocks in urllib.parse.rst (GH-21500)
d4a6303 
This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella
(cherry picked from commit 5e5c0f9)

Co-authored-by: Christopher Yeh <chrisyeh96@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jul 16, 2020
@miss-islington @chrisyeh96
Remove unnecessary spaces in code blocks in urllib.parse.rst (GH-21500)
f0f6566 
This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella
(cherry picked from commit 5e5c0f9)

Co-authored-by: Christopher Yeh <chrisyeh96@users.noreply.github.com>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@chrisyeh96 @arun-mani-j
Remove unnecessary spaces in code blocks in urllib.parse.rst (pythonG…
66cb014 
…H-21500)

This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@chrisyeh96 @shihai1991
Remove unnecessary spaces in code blocks in urllib.parse.rst (pythonG…
4b9dfef 
…H-21500)

This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@chrisyeh96 @shihai1991
Remove unnecessary spaces in code blocks in urllib.parse.rst (pythonG…
6842187 
…H-21500)

This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@chrisyeh96
Remove unnecessary spaces in code blocks in urllib.parse.rst (pythonG…
d09a825 
…H-21500)

This should also fix the syntax highlighting for these code blocks

Automerge-Triggered-By: @csabella
@chrisyeh96 chrisyeh96 deleted the patch-2 branch September 14, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella approved these changes

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisyeh96 @miss-islington @bedevere-bot @csabella @the-knights-who-say-ni