Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use PyTuple_Resize #436

Merged
merged 9 commits into from Jul 3, 2020
Merged

Don't use PyTuple_Resize #436

merged 9 commits into from Jul 3, 2020

Conversation

@methane
Copy link
Member

@methane methane commented Jul 2, 2020

It is unsafe.

Fixes #435.
See also #348.

methane added 3 commits Jul 2, 2020
It is unsafe.
fix
@PyMySQL PyMySQL deleted a comment from codecov bot Jul 2, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 2, 2020

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          12       12           
  Lines        1536     1536           
=======================================
  Hits         1331     1331           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0887495...52bd513. Read the comment docs.

methane added 2 commits Jul 2, 2020
@methane methane closed this Jul 2, 2020
@methane methane reopened this Jul 2, 2020
methane added 2 commits Jul 2, 2020
@methane
Copy link
Member Author

@methane methane commented Jul 3, 2020

It seems Django tests uses much memory and Travis-Ci can not finish the test.
I am running the test locally.

methane added 2 commits Jul 3, 2020
@methane methane merged commit a825b84 into PyMySQL:master Jul 3, 2020
6 checks passed
6 checks passed
LGTM analysis: Python No code changes detected
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
codecov/patch Coverage not affected when comparing 0887495...52bd513
Details
codecov/project 86.65% (+0.00%) compared to 0887495
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@methane methane deleted the methane:ban-tupleresize branch Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.