Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Send a warning instead throwing an exeption when message type is not … #422
Conversation
…compatible with as_copy
|
@delivrance do you prefer a |
|
I tried to forward three messages, two texts and one service in the middle; the server successfully forwards the two texts. I approve this. |
I'd rather keep the code simpler and mention in the release note about this possible breaking change. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
…compatible with as_copy
As messages copies are often done in batches, send a warning and continue the work is a far better behavior (so much user friendly).