Removed unused variable m.

[himadriganguly]

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[cclauss]

Suggested change

	def dp_count(S, n):
	"""
	>>> dp_count([1, 2, 3], 3, 4)
	from typing import List, Optional
	def coin_change(make_change_for: int, coin_types: List[int] = None) -> int:
	"""
	>>> coin_change(4, [1, 2, 3])

If the doctests are not modified to match the function then our automated tests will fail.

While we are here, let's modify the function to use self-documenting names for function and variables. Let's also add Python type hints.

[cclauss]

Before line 24 we could give coin_types a default value by adding the line coin_types = coin_types or (1, 5, 10, 25, 100)

This would allow a call such as coin_change(17).

[himadriganguly]

Updated the doctests.

Before line 24 we could give coin_types a default value by adding the line coin_types = coin_types or (1, 5, 10, 25, 100)
This would allow a call such as coin_change(17).

Didn't get this point can you please explain.

[cclauss]

Please add a test where make_change_for = -5. How should the algorithm behave with that input?

[himadriganguly]

Please add a test where make_change_for = -5. How should the algorithm behave with that input?

Added condition for negative values and the doctest.

[TravisBuddy]

Hey @himadriganguly,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 373c2f10-c6db-11ea-aa06-e17841301e13

[TravisBuddy]

Hey @himadriganguly,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 20a30200-c6dc-11ea-aa06-e17841301e13

[ruppysuppy]

The doctest is failing

[TravisBuddy]

Travis tests have failed

Hey @himadriganguly,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e2aef8b0-ca9f-11ea-84bb-258f0278865c

[ruppysuppy]

The doctests are failing, make sure that all the doctests are successful

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.