Skip to content

Conversation

@sjadlakha
Copy link

Describe your change:

Solved issue #2282. SettingWithCopy warning in machine learning/k_means_clust.py.
Have set the changed_assignment option in pandas.options.mode to None.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@sjadlakha
Copy link
Author

Hey, can you review my pull request?

@satorutakada
Copy link

この度は私の為に、ありがとうございます。私は正直な所なんとなーく雰囲気でしか分かりません。何もかもが初めてなので、事前に深く考えるのは辞めようと思います。いつも行き当たりばったりだったので。
私仕事がありますので、何とかして頑張りますので。これいつ来るとか分からないのですか?わからないですよね。

@satorutakada
Copy link

警告は無視してもいいということですね。
何年だろう。ずっと押し込められてた気がしててスッキリすることあまりなかったけど、やっと自由になれるのかなって期待してます。
現実は残酷で辛いこともありましたが、最後が良ければそれが一番です。

@cclauss
Copy link
Member

cclauss commented Aug 7, 2020

@sjadlakha The goal is not to turn off the warnings. The goal is to fix the code so that it does not generate any warnings.

@sjadlakha
Copy link
Author

@sjadlakha The goal is not to turn off the warnings. The goal is to fix the code so that it does not generate any warnings.

Sure, will fix it. Thanks

@sjadlakha sjadlakha closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants