Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort --profile black . #2181

Merged
merged 7 commits into from Jul 6, 2020
Merged

isort --profile black . #2181

merged 7 commits into from Jul 6, 2020
+123 −127

Conversation

@cclauss
Copy link
Member

cclauss commented Jul 6, 2020

Describe your change:

Run isort --profile black . on the entire repo and add that command to our Autoblack GitHub Action.

--recursive was removed from isort in v5.0 https://timothycrosley.github.io/isort/CHANGELOG

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actions and others added 5 commits Jun 16, 2020
github-actions github-actions
updating DIRECTORY.md
307f09e
@cclauss
Merge branch 'master' of https://github.com/cclauss/Python-3
a95fb08
@cclauss
Merge branch 'master' of https://github.com/TheAlgorithms/Python
142cb8c
@cclauss
Merge branch 'master' of https://github.com/TheAlgorithms/Python
987cd9d
@cclauss
isort --profile black .
72a5dfa
@cclauss cclauss requested review from mateuszz0000, mrvnmchm and itsvinayak Jul 6, 2020
@cclauss
Black after
Loading status checks…
d5734e4
@cclauss cclauss force-pushed the cclauss:isort--profile-black--recursive branch from fbb2495 to d5734e4 Jul 6, 2020
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
1330fe2
@cclauss cclauss requested a review from poyea Jul 6, 2020
@poyea
poyea approved these changes Jul 6, 2020
View changes
Copy link
Member

poyea left a comment

👌
@cclauss cclauss merged commit 5f4da5d into TheAlgorithms:master Jul 6, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@cclauss cclauss deleted the cclauss:isort--profile-black--recursive branch Jul 6, 2020
@Isabellarossi
Copy link

Isabellarossi commented Aug 6, 2020

Describe your change:

Run isort --profile black . on the entire repo and add that command to our Autoblack GitHub Action.

--recursive was removed from isort in v5.0 https://timothycrosley.github.io/isort/CHANGELOG

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

@mrvnmchm mrvnmchm

@mateuszz0000 mateuszz0000

@itsvinayak itsvinayak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@cclauss @Isabellarossi @poyea
You can’t perform that action at this time.