Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N queens math #2175

Merged
merged 19 commits into from Jul 10, 2020
Merged

N queens math #2175

merged 19 commits into from Jul 10, 2020
+165 −0

Conversation

@DavidBanda
Copy link
Contributor

DavidBanda commented Jul 5, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
DavidBanda added 2 commits Jun 29, 2020
@DavidBanda
add new file for another solution to the n queens problem
1483887
@DavidBanda
Add the code for the algorithm, add comments and add at the top a gen…
Loading status checks…
105d9ee 
…eral explanation
@TravisBuddy
Copy link

TravisBuddy commented Jul 5, 2020

Hey @DavidBanda,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: dec05400-be57-11ea-b6c3-5fc2c9c22d2c
@cclauss
Copy link
Member

cclauss commented Jul 5, 2020

How is this better than https://github.com/TheAlgorithms/Python/blob/master/backtracking/n_queens.py ?
@cclauss
cclauss requested changes Jul 5, 2020
View changes
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Jul 5, 2020
View changes
backtracking/n_queens_math.py Show resolved Hide resolved
DavidBanda and others added 4 commits Jul 5, 2020
@DavidBanda @cclauss
Update backtracking/n_queens_math.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5222388 
Co-authored-by: Christian Clauss <cclauss@me.com>
@DavidBanda @cclauss
Update backtracking/n_queens_math.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e65b5a7 
Co-authored-by: Christian Clauss <cclauss@me.com>
@DavidBanda @cclauss
Update backtracking/n_queens_math.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6692361 
Co-authored-by: Christian Clauss <cclauss@me.com>
@DavidBanda @cclauss
Update backtracking/n_queens_math.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e6d572 
Co-authored-by: Christian Clauss <cclauss@me.com>
@TravisBuddy
Copy link

TravisBuddy commented Jul 5, 2020

Hey @DavidBanda,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d95c4fc0-be78-11ea-b6c3-5fc2c9c22d2c
@DavidBanda
No newline at the end of the file
Loading status checks…
2af2536
@TravisBuddy
Copy link

TravisBuddy commented Jul 5, 2020

Hey @DavidBanda,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7f03d7e0-be79-11ea-b6c3-5fc2c9c22d2c
@DavidBanda
Type hints
Loading status checks…
42a5cfb
@TravisBuddy
Copy link

TravisBuddy commented Jul 6, 2020

Hey @DavidBanda,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a5b11690-bfba-11ea-8212-0f9c14daf924
@DavidBanda
whitespaces fixed
Loading status checks…
c821598
@TravisBuddy
Copy link

TravisBuddy commented Jul 6, 2020

Hey @DavidBanda,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 13acf3c0-bfbc-11ea-8212-0f9c14daf924
DavidBanda added 4 commits Jul 6, 2020
@DavidBanda
Fixed whitespaces
Loading status checks…
b62b637
@DavidBanda
Add type hints
Loading status checks…
2bd7aee
@DavidBanda
CodeSpell fixed
Loading status checks…
0f96b60
@DavidBanda
update
Loading status checks…
af938a0
@DavidBanda
Copy link
Contributor Author

DavidBanda commented Jul 6, 2020

Its not better than https://github.com/TheAlgorithms/Python/blob/master/backtracking/n_queens.py. Its just another solution to the problem of n queens.
@DavidBanda DavidBanda requested a review from cclauss Jul 7, 2020
@cclauss
cclauss requested changes Jul 7, 2020
View changes
Copy link
Member

cclauss left a comment

Let's add type hints and let's have depth_first_search() return a board (the search result) instead of passing in boards each time.
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
backtracking/n_queens_math.py Outdated Show resolved Hide resolved
DavidBanda added 2 commits Jul 7, 2020
@DavidBanda
All changes made except changing the board variable to local
6989f83
@DavidBanda
Add doctest
Loading status checks…
7c63b77
@TravisBuddy
Copy link

TravisBuddy commented Jul 7, 2020

Hey @DavidBanda,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ac9689d0-c08d-11ea-8f0c-c508e01afe59
DavidBanda added 2 commits Jul 7, 2020
@DavidBanda
Update
Loading status checks…
68b573d
@DavidBanda
Update
Loading status checks…
de33d23
@DavidBanda
Copy link
Contributor Author

DavidBanda commented Jul 7, 2020

Hey, how's it going? I added all the changes you requested except for the one that said to use boards as a local variable within depth_first_search() because I don't know how to do it without the algorithm misbehaving.
@DavidBanda DavidBanda requested a review from cclauss Jul 7, 2020
@DavidBanda
Update
Loading status checks…
26eb205
@cclauss
Copy link
Member

cclauss commented Jul 9, 2020

Sorry for the delay... I will review this and land it in 24 hours.
@DavidBanda
Copy link
Contributor Author

DavidBanda commented Jul 10, 2020

Don't worry about it
@cclauss
Update n_queens_math.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6fbceb5
@cclauss
cclauss approved these changes Jul 10, 2020
View changes
@cclauss cclauss merged commit 05c14c6 into TheAlgorithms:master Jul 10, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
@cclauss
Copy link
Member

cclauss commented Jul 10, 2020

Thanks!
@DavidBanda DavidBanda deleted the DavidBanda:n-queens-math branch Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@DavidBanda @TravisBuddy @cclauss
You can’t perform that action at this time.