Add Placing Parentheses and update README #2222

srivastavaayu · 2020-07-21T20:47:23Z


        Add Placing Parentheses

Added Placing Parenthesis (the question is to maximize an expression by rearranging operands and operators) in Dynamic Programming subdirectory.


        Update README.md

Add repo license details with a link to the license file in the directory.

TravisBuddy · 2020-07-21T20:50:47Z

Hey @srivastavaayu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d9303e30-cb93-11ea-96be-d1d226963d5e

ruppysuppy

Read the CONTRIBUTING.md and add type hints, doctests and proper flake8 formatting

ruppysuppy

@cclauss, please review this one

dynamic_programming/parentheses.py

cclauss · 2020-07-22T05:06:58Z

Codespell says:

./dynamic_programming/parentheses.py:24: parantheses ==> parentheses
./dynamic_programming/parentheses.py:43: parantheses ==> parentheses


        Update parentheses.py

Updated parentheses.py with type hints, checked code formatting using black and flake8

TravisBuddy · 2020-07-22T19:05:25Z

Travis tests have failed

Hey @srivastavaayu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4ac548a0-cc4e-11ea-acda-6fc69b852bf0


        Update parentheses.py

Updated parentheses.py with type hints, checked code formatting using black and flake8

TravisBuddy · 2020-07-22T19:36:46Z

Travis tests have failed

Hey @srivastavaayu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 93fbd1c0-cc52-11ea-acda-6fc69b852bf0

cclauss · 2020-07-22T20:37:22Z

https://docs.python.org/3/library/operator.html

from operator import add, sub, mul, floordiv

operators = {
    "+": add,
    "-": sub,
    "*": mul,
    "/": floordiv,  # or truediv,
}


def calculate(a: int, b: int, op: str) -> int:
    return operators[op](a, b)

dynamic_programming/parentheses.py


        Update parentheses.py

Update parentheses.py and now using built-in addition, subtraction, and multiplication operators and also renamed variables to reflect their purpose.

TravisBuddy · 2020-07-22T21:49:04Z

Hey @srivastavaayu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 27f19b50-cc65-11ea-acda-6fc69b852bf0

parentheses.py


        Update parentheses.py

Update parentheses.py and now using built-in addition, subtraction, and multiplication operators and also renamed variables to reflect their purpose.


        Update parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>


        Delete parentheses.py

parentheses.py

TravisBuddy · 2020-07-22T21:56:32Z

Hey @srivastavaayu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 333e1aa0-cc66-11ea-acda-6fc69b852bf0

parentheses.py

TravisBuddy · 2020-07-22T22:03:47Z

Travis tests have failed

Hey @srivastavaayu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 357ca380-cc67-11ea-acda-6fc69b852bf0

srivastavaayu · 2020-07-22T22:06:15Z

@cclauss I don't understand. I've possibly done every change suggested by you. Let me try and incorporate changes suggested by you once again. But is there any specific reason the build is failing?

cclauss

The main code with an input() statement must be indented under if __name__ == "__main__": to avoid hanging pytest. This is discussed in CONTRIBUTING.md.

README.md

dynamic_programming/parentheses.py

cclauss · 2020-07-23T07:44:35Z

dynamic_programming/parentheses.py

+
+def calculate(first_operand, second_operand, operator) -> int:
+    """
+    Return the value after evaluating the expression


Type hints on function parameters needed and doc tests needed.

Please add the following doctest...

Suggested change

Return the value after evaluating the expression

Evaluate the expression and return the result.

>>> calculate("2+2") # add()

4

>>> calculate("2-2") # sub()

0

>>> calculate("2*2") # mul

4

Once this is done, on you local machine, do python3 -m doctest -v paraentheses.py

doctests are how we ensure that our function works the way that we think it should and how we document to others how it should be called.

cclauss · 2020-07-23T07:44:35Z

dynamic_programming/parentheses.py

+    return operators[operator](first_operand, second_operand)
+
+
+def MinandMax(maximum_numbers, minimum_numbers, i, j, operator) -> int:


Type hints on function parameters needed and doc tests needed.

dynamic_programming/parentheses.py


        Update dynamic_programming/parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>


        Update README.md

Co-authored-by: Christian Clauss <cclauss@me.com>


        Update parentheses.py

srivastavaayu · 2020-07-24T00:49:15Z

@cclauss All the tests have passed successfully. Please review this PR. And suggest changes, if any.

poyea

@srivastavaayu Thanks for the contribution! Could you add a few doctests & type hints and comment (what's the expected input and output) in the code to demonstrate the function? We need these to have this landed. If you're in doubt, you can see our CONTRIBUTING.md that will give you a clearer idea.

srivastavaayu added 2 commits Jul 21, 2020

ruppysuppy suggested changes Jul 22, 2020

View changes

ruppysuppy reviewed Jul 22, 2020

View changes