Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove remaining travis leftovers #27979

Closed
wants to merge 2 commits into from
Closed

build: remove remaining travis leftovers #27979

wants to merge 2 commits into from
+28 −134

Conversation

@devversion
Copy link
Member

devversion commented Jan 8, 2019 •
edited

  • There still seem to be a few TravisCI leftovers which can be removed now.
  • Also fixes that a few e2e tests aren't running. These have been disabled a long time ago, but can be re-enabled now.
@devversion devversion requested review from IgorMinar and angular/docs-infra as code owners Jan 8, 2019
@googlebot googlebot added the cla: yes label Jan 8, 2019
@mary-poppins
Copy link

mary-poppins commented Jan 8, 2019

You can preview 5f4ef73 at https://pr27979-5f4ef73.ngbuilds.io/.
@devversion devversion force-pushed the devversion:chore/remove-travis-leftovers branch from 4d73686 to f4d4e7b Jan 8, 2019
@mary-poppins
Copy link

mary-poppins commented Jan 8, 2019

You can preview f4d4e7b at https://pr27979-f4d4e7b.ngbuilds.io/.
devversion added 2 commits Jan 8, 2019
@devversion
build: remove travisci leftovers
Loading status checks…
aba7d75
@devversion
build: re-enable disabled e2e tests
Loading status checks…
f335215 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.
@devversion devversion force-pushed the devversion:chore/remove-travis-leftovers branch from f4d4e7b to f335215 Jan 8, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 8, 2019
@mary-poppins
Copy link

mary-poppins commented Jan 8, 2019

You can preview f335215 at https://pr27979-f335215.ngbuilds.io/.
@gkalpak
gkalpak approved these changes Jan 8, 2019
View changes
@IgorMinar
IgorMinar approved these changes Jan 9, 2019
View changes
Copy link
Member

IgorMinar left a comment

thanks!
@IgorMinar
Copy link
Member

IgorMinar commented Jan 9, 2019

http://test/OCL:228478868:BASE:228478898:1547027617834:a494b147
@IgorMinar
Copy link
Member

IgorMinar commented Jan 9, 2019

caretaker note: pending review check is invalid because the PR has global approver approval

@ocombe this is a good example of when robot should not complain about pending reviews.
@ocombe
Copy link
Contributor

ocombe commented Jan 9, 2019

I removed the merge-assistance label as the bot is now able to ignore team review requests.
AndrewKushnir added a commit that referenced this pull request Jan 9, 2019
@devversion @AndrewKushnir
build: remove travisci leftovers (#27979)
Loading status checks…
e0ed78c 
PR Close #27979
AndrewKushnir added a commit that referenced this pull request Jan 9, 2019
@devversion @AndrewKushnir
build: re-enable disabled e2e tests (#27979)
Loading status checks…
84857a2 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
AndrewKushnir added a commit that referenced this pull request Jan 9, 2019
@devversion @AndrewKushnir
build: re-enable disabled e2e tests (#27979)
Loading status checks…
31fdff7 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
AndrewKushnir added a commit that referenced this pull request Jan 16, 2019
@devversion @AndrewKushnir
build: remove travisci leftovers (#27979)
Loading status checks…
11728bb 
PR Close #27979
AndrewKushnir added a commit that referenced this pull request Jan 16, 2019
@devversion @AndrewKushnir
build: re-enable disabled e2e tests (#27979)
Loading status checks…
bea6771 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@devversion @ngfelixl
build: remove travisci leftovers (angular#27979)
2c60e79 
PR Close angular#27979
ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@devversion @ngfelixl
build: re-enable disabled e2e tests (angular#27979)
7fcabbb 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close angular#27979
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar

@gkalpak gkalpak

@angular/fw-testing fw-testing

Assignees
No one assigned
Labels
PR action: merge PR target: master & patch cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@devversion @mary-poppins @IgorMinar @ocombe @gkalpak @googlebot
You can’t perform that action at this time.