C#: Fix computed sizes for implicitly sized array creation#4126
Merged
calumgrant merged 6 commits intogithub:mainfrom Aug 28, 2020
Merged
C#: Fix computed sizes for implicitly sized array creation#4126calumgrant merged 6 commits intogithub:mainfrom
calumgrant merged 6 commits intogithub:mainfrom
Conversation
hvitved
reviewed
Aug 26, 2020
Contributor
hvitved
left a comment
There was a problem hiding this comment.
It looks like we are still missing some array lengths; I have suggested a change to the QL API, let me know what you think (that change would also require all RankSpecifiers to be extracted).
Contributor
|
We should probably add a small change note about this fix. |
hvitved
previously approved these changes
Aug 26, 2020
calumgrant
suggested changes
Aug 26, 2020
Contributor
calumgrant
left a comment
There was a problem hiding this comment.
Sorry, tedious typo. But great work!
calumgrant
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.