Python more complete dataflow tests#4154
Merged
yoff merged 13 commits intogithub:mainfrom Sep 4, 2020
Merged
Conversation
The ones in test/experimental/dataflow/[consistency,regression]/test.py was a copy from test/library-tests/taint/dataflow/test.py. However, test/library-tests/taint/dataflow/test.py only contains a subset of test/library-tests/taint/config/test.py, that only contains a subset of test/library-tests/taint/general/test.py This commit updates the experimental dataflow tests to be a copy of the test/library-tests/taint/general/test.py file. There seems to have been a few changes to the file after it being copied, in `test_truth` and `test_early_exit`. I have no reproduced those changes.
I did not verify whether these changes are OK or not, simply ran and accepted the tests.
Also add test of custom flow
they will be reintroduced in an other PR
…aflow-tests Small fixups to your PR to my PR
…w-tests Python: Annotate test file
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ones in test/experimental/dataflow/[consistency,regression]/test.py was a copy from test/library-tests/taint/dataflow/test.py.
However, test/library-tests/taint/dataflow/test.py only contains a subset of test/library-tests/taint/config/test.py, that only contains a subset of test/library-tests/taint/general/test.py
This commit updates the experimental dataflow tests to be a copy of the test/library-tests/taint/general/test.py file.
There seems to have been a few changes to the file after it being copied, in
test_truthandtest_early_exit. I have no reproduced those changes.I did not verify whether these changes are OK or not, simply ran and accepted the tests.
@yoff I hope you will take over this PR and see whether it makes sense to add the new tests cases, and whether the results look reasonable or not. 🙏