Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added static type checking to Python/linear_algebra/src/power_iterati… #2336

Open
wants to merge 3 commits into
base: master
from
Open

Added static type checking to Python/linear_algebra/src/power_iterati… #2336

wants to merge 3 commits into from

Conversation

@karan-dhir
Copy link

karan-dhir commented Aug 18, 2020

…on.py

Describe your change:

Added static type checking to power_iteration.py towards issue #2128.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@karan-dhir
Added static type checking to Python/linear_algebra/src/power_iterati…
Loading status checks…
6948ec4 
…on.py
@TravisBuddy
Copy link

TravisBuddy commented Aug 18, 2020

Hey @karan-dhir,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ba646be0-e153-11ea-81c3-ef1e647c3fbd
@karan-dhir
Fixed errors in build by TravisCI
Loading status checks…
1aae208
@TravisBuddy
Copy link

TravisBuddy commented Aug 18, 2020

Hey @karan-dhir,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e2cbf020-e154-11ea-81c3-ef1e647c3fbd
@karan-dhir
Fixed errors in second build by TravisCI
Loading status checks…
11db7af
@swapnanildutta
swapnanildutta approved these changes Aug 26, 2020
View changes
@cclauss
cclauss reviewed Aug 26, 2020
View changes
linear_algebra/src/power_iteration.py
convergence: bool = False
lamda_previous: int = 0
iterations: int = 0
error: float = 1e12
Comment on lines +47 to +50

This comment has been minimized.

Sign in to view
@cclauss

cclauss Aug 26, 2020

Member

Type hints are not really required on local variables that are set to literals. They create a lot of cognitive clutter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@swapnanildutta swapnanildutta

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@karan-dhir @TravisBuddy @cclauss @swapnanildutta
You can’t perform that action at this time.