Skip to content

Conversation

@yoff
Copy link
Contributor

@yoff yoff commented Aug 25, 2020

This PR improves our handling of nested comprehensions.

@yoff yoff added the Python label Aug 25, 2020
@yoff yoff requested a review from a team as a code owner August 25, 2020 13:38
RasmusWL
RasmusWL previously approved these changes Aug 26, 2020
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure whether we should mention the new functionality in Comp in the release notes, but @tausbn might know 😊

@tausbn
Copy link
Contributor

tausbn commented Sep 2, 2020

The added Comp functionality seems like a small enough change that we don't need to explicitly mention it (but that's just my personal opinion).

This looks ready to merge once the conflicts have been resolved (and tests rerun, etc.).

Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me

@RasmusWL RasmusWL merged commit f716f96 into github:main Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants