Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created problem_63 in project_euler #2357

Merged
merged 6 commits into from Aug 27, 2020
Merged

Created problem_63 in project_euler #2357

merged 6 commits into from Aug 27, 2020

Conversation

@Kush1101
Copy link
Contributor

Kush1101 commented Aug 27, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Kush1101 added 2 commits Aug 27, 2020
@Kush1101
Create __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c94f06c
@Kush1101
Add files via upload
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d55b376
@Kush1101
Copy link
Contributor Author

Kush1101 commented Aug 27, 2020

@cclauss Please review it.
@cclauss
cclauss requested changes Aug 27, 2020
View changes
project_euler/problem_63/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_63/sol1.py Outdated Show resolved Hide resolved
Kush1101 and others added 2 commits Aug 27, 2020
@Kush1101 @cclauss
Update project_euler/problem_63/sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ebe1cb1 
Co-authored-by: Christian Clauss <cclauss@me.com>
@Kush1101
Update sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
866863b
@TravisBuddy
Copy link

TravisBuddy commented Aug 27, 2020

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: aca837a0-e84e-11ea-a3ad-29627dfdd765
@Kush1101 Kush1101 requested a review from cclauss Aug 27, 2020
@cclauss
cclauss reviewed Aug 27, 2020
View changes
project_euler/problem_63/sol1.py Outdated Show resolved Hide resolved
@Kush1101
Update sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ad77626
@Kush1101 Kush1101 requested a review from cclauss Aug 27, 2020
@cclauss
Copy link
Member

cclauss commented Aug 27, 2020

Please add doctests for 1, 0, -1
@Kush1101
Update sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5dfa461
@cclauss
cclauss approved these changes Aug 27, 2020
View changes
@cclauss cclauss merged commit 194b56d into TheAlgorithms:master Aug 27, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Kush1101 @TravisBuddy @cclauss
You can’t perform that action at this time.