Enable -Wundef compiler warning #5526
Open
Conversation
04ee8ee
to
2da480a
Closed
d789c7a
to
a32cc30
1d9f817
to
ed23794
Closed
ce4316d
to
5c19ecf
9cff451
to
c6fad3d
91b2ad7
to
b859ca2
5ddec73
to
1e4cf4f
This constant is used in zend.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is not enabled by -Wextra and seems like something sane to have which is not much effort to make work.
Except for this one:
Which is generated by Bison but I also don't understand why the compilers are complaining as the generated code is (at least locally):
Note, I realized that the following macros are always defined, but only on Windows:
Fixed with: ca6dd7e
AC_DEFINE('HAVE_GETADDRINFO', main_network_has_ipv6);See https://heap.space/xref/php-src/win32/build/config.w32?r=84854a72#283
Review list:
HAVE_ENCHANT_BROKER_SET_PARAMor need to always be defined for Nux* or need to drop always defined on Windows and adjust #if/#ifdef accordingly#if FFI_CLOSURESneed to be#ifdef FFI_CLOSURES?HAVE_GETADDRINFOissue before finishedHAVE_GETADDRINFOissue before finishedXMLRPCIgnoring this as it's getting unbundled