Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDSTACK-10331: Remove reference to deleted script vm_snapshots.js #2497

Merged
merged 1 commit into from Mar 21, 2018
Merged

CLOUDSTACK-10331: Remove reference to deleted script vm_snapshots.js #2497

merged 1 commit into from Mar 21, 2018

Conversation

olivierlemasle
Copy link
Contributor

Description

CloudStack main page requests a script "client/scripts/vm_snapshots.js", which does exist since ACS 4.10, causing a HTTP 404 error.

This commit remove the references to this deleted file (deleted in commit a242850)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

Run CloudStack and access to UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rafaelweingartner
Copy link
Member

Thanks @olivierlemasle for the fix.

@rafaelweingartner rafaelweingartner added this to the 4.12.0.0 milestone Mar 20, 2018
@olivierlemasle olivierlemasle force-pushed the remove-vm-snapshot branch 4 times, most recently from c4045e3 to 6aab70b Compare March 20, 2018 22:50
borisstoyanov
borisstoyanov approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelweingartner rafaelweingartner merged commit 3e62ce9 into apache:master Mar 21, 2018
@olivierlemasle olivierlemasle deleted the remove-vm-snapshot branch March 21, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelweingartner rafaelweingartner rafaelweingartner approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

@olivierlemasle olivierlemasle

Labels
component:UI type:bug
Projects
None yet
Milestone
4.12.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olivierlemasle @rafaelweingartner @borisstoyanov