Log command output in CsHelper.execute command #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1914 |
nitin-maharana
approved these changes
Apr 13, 2018
| @@ -188,6 +188,8 @@ def execute(command): | |||
| logging.info("Executing: %s" % command) | |||
| result = subprocess.check_output(command, shell=True) | |||
| returncode = 0 | |||
|
|
|||
| logging.debug("Command [%s] has the result [%s]" % (command, result)) | |||
There was a problem hiding this comment.
@rafaelweingartner this may quickly fill up /var/log, otherwise LGTM.
rohityadavcloud
approved these changes
Apr 13, 2018
|
@rhtyd it is not enabled by default. That is why I used the 'DEBUG' level. |
|
@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While debugging some problems in our VRs, we noticed that the result of commands (e.g. iptables) was not being logged. It is interesting to log these information (at least in debug level) to facilitate troubleshooting.
This PR enables
CsHelper.executeto log DEBUG level the result of commands being executed.Types of changes
How Has This Been Tested?
Locally
Checklist:
Testing
@blueorangutan package