Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included eval #218

Merged
merged 7 commits into from May 11, 2020
Merged

included eval #218

merged 7 commits into from May 11, 2020

Conversation

@clacri
Copy link
Collaborator

@clacri clacri commented May 10, 2020

No description provided.

Copy link
Collaborator

@humitos humitos left a comment

Genial! Te hice unas pequeñas sugerencias, que si las aceptas está listo para hacer merge 😄

library/functions.po Show resolved Hide resolved
library/functions.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@marian-vignau marian-vignau left a comment

Muy buen trabajo!
Gracias!

library/functions.po Outdated Show resolved Hide resolved
library/functions.po Outdated Show resolved Hide resolved
library/functions.po Outdated Show resolved Hide resolved
clacri and others added 5 commits May 10, 2020
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: marian-vignau <mavignau@gmail.com>
Co-authored-by: marian-vignau <mavignau@gmail.com>
Co-authored-by: marian-vignau <mavignau@gmail.com>
@clacri
Copy link
Collaborator Author

@clacri clacri commented May 10, 2020

He aceptado vuestras sugerencias, gracias por la revisión. Lo de la configuración de las comillas me lo revisaré antes de hacer otro PR, gracias por el aviso.

@humitos humitos dismissed marian-vignau’s stale review May 11, 2020

Ya los arregló :)

@humitos
Copy link
Collaborator

@humitos humitos commented May 11, 2020

Gracias @clacri, sos una genia!

@humitos humitos merged commit ec9dd05 into 3.8 May 11, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docs/readthedocs.org:python-docs-es Read the Docs build succeeded!
Details
@humitos humitos deleted the claudia_functions_38 branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.