C#: Skip foreach loop bodies in the CFG when the iteration expression is empty
#4139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bea3b2 to
dc064f5
Compare
tamasvajk
previously approved these changes
Sep 7, 2020
dc064f5 to
6c71633
Compare
Contributor
Author
|
Rebased to resolve merge conflicts in |
Contributor
Author
|
@tamasvajk : Can you please re-approve? Thanks |
tamasvajk
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out to be very easy to generalize the existing logic for unfolding
foreachloops where the iterator expression is guaranteed non-empty to also include skipping the loop body when the iterator expression is guaranteed empty. This is probably not likely to happen often in practice (the CSharp-Differences job shows no changes in results), but again the change was so small that I thought it was still worthwhile.