Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor view results: add space after the spinner in the download button #10615

Closed
damithc opened this issue Aug 16, 2020 · 13 comments
Closed

Instructor view results: add space after the spinner in the download button #10615

damithc opened this issue Aug 16, 2020 · 13 comments

Comments

@damithc
Copy link
Contributor

@damithc damithc commented Aug 16, 2020

image

In the Download results button, add a space between the spinner and the button label when a download is in progress.

@damithc damithc added the p.VeryLow label Aug 16, 2020
@niqiukun
Copy link
Contributor

@niqiukun niqiukun commented Aug 16, 2020

Possible to work on #10425 instead for a neater look.

@bcbabrich
Copy link

@bcbabrich bcbabrich commented Aug 24, 2020

I would like to claim this issue if possible. I am new to open source work so I may take a while. I'll move on to #10425 afterwards if I'm successful with this one.

@madanalogy
Copy link
Member

@madanalogy madanalogy commented Oct 3, 2020

I would like to claim this issue if possible. I am new to open source work so I may take a while. I'll move on to #10425 afterwards if I'm successful with this one.

Sure, please read our contributing guide and development guide, then submit a PR when you're ready. Let us know if you need any help.

@ripudaman1320
Copy link
Contributor

@ripudaman1320 ripudaman1320 commented Oct 4, 2020

Hi @madanalogy / @damithc

I would like to work on this issue as part of #Hacktoberfest. May I know if there's a channel available for communications ?

Thanks!
-Ripu

@t-cheepeng
Copy link
Contributor

@t-cheepeng t-cheepeng commented Oct 5, 2020

Hi @ripudaman1320 , you can work on this issue since the previous person has not responded/opened a PR for some time. You can communicate with us using this issue's conversations. All the best! Let us know if you require any help

@ripudaman1320
Copy link
Contributor

@ripudaman1320 ripudaman1320 commented Oct 9, 2020

I have few doubts -
a. Do i need to start off with my master branch only to make changes or do i need to create a feature branch for the same?

https://github.com/TEAMMATES/teammates/blob/master/docs/process.md

For brevity, this instruction set will use master branch as the base branch. Any reference to the master branch should be replaced with the base branch that applies to your case.

  1. Start off from your master branch and make sure it is up-to-date with the latest version of the main repo's master branch.

git checkout master
git pull
2. Create a new branch to push your commits into. If you have commit access and need to push into the main repo for some reason, name it {IssueNumber}-{some-keywords}, where some-keywords are representative keywords taken from the issue title.

git checkout -b 3942-remove-unnecessary-println

b. Can you paste the link of the issue or steps to replicate the same on my dev server.

@t-cheepeng
Copy link
Contributor

@t-cheepeng t-cheepeng commented Oct 10, 2020

@ripudaman1320

a. Do i need to start off with my master branch only to make changes or do i need to create a feature branch for the same?

You would need to start from your master branch and checkout a new branch as stated in the process guide

b. Can you paste the link of the issue or steps to replicate the same on my dev server.

Once you have set up your dev server, go to any sessions > click on Results > click on View Results > click on Download Results

@ayush015
Copy link

@ayush015 ayush015 commented Oct 10, 2020

if this issue is still up for grabs I would like handle it !

@ripudaman1320
Copy link
Contributor

@ripudaman1320 ripudaman1320 commented Oct 10, 2020

@ripudaman1320

a. Do i need to start off with my master branch only to make changes or do i need to create a feature branch for the same?

You would need to start from your master branch and checkout a new branch as stated in the process guide

b. Can you paste the link of the issue or steps to replicate the same on my dev server.

Once you have set up your dev server, go to any sessions > click on Results > click on View Results > click on Download Results

Thanks @t-cheepeng

@ripudaman1320
Copy link
Contributor

@ripudaman1320 ripudaman1320 commented Oct 10, 2020

@t-cheepeng , I'm logged-in as admin but when i go to sessions, i don't see any ongoing session. Also i tried to filter by Range but still nothing showed up.
Capture

@t-cheepeng
Copy link
Contributor

@t-cheepeng t-cheepeng commented Oct 11, 2020

@ripudaman1320 Follow the guide here. You would have to create instructors first.

@ripudaman1320
Copy link
Contributor

@ripudaman1320 ripudaman1320 commented Oct 11, 2020

I have opened a PR. Please have a look. Thanks!

@mbrat06
Copy link

@mbrat06 mbrat06 commented Dec 6, 2020

Hello, we are a group of students new to open-source and tried to fix this issue. Would you please have a look ? Thanks !

madanalogy added a commit that referenced this issue Dec 8, 2020
…download button (#10778)

* Add margin-right of 10px in ajax-loading scss

* Removed &nbsp from three html files

* Removed white space after loading icon

* Changes reverted for removal of incorrect white spaces

Co-authored-by: Singh <Ripudaman.Singh@CenturyLink.com>
Co-authored-by: Ahmed Bahajjaj <Ahmed_Bahajjaj@u.nus.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants