Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: relay jenkins and gh events to gh #272
Conversation
`github` has been renamed to `@octokit/rest`. The version sequence was kept, and the package name is the only breaking change on v14.0.0. Ref: https://github.com/octokit/rest.js/releases/tag/v14.0.0
Only breaking change on v15.0.1 is to `DELETE` calls, which we don't use. Ref: https://github.com/octokit/rest.js/releases/tag/v15.0.1
|
Ah, one thing we need for GitHub events is to differentiate events coming from people with write access to the repo vs people without write access to it. We can append a |
|
That sounds convenient indeed! |
|
Oh nice, the GitHub part of this PR was rendered unnecessary by GitHub earlier this week: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/. With the new event announced in this blog post we can move everything we have here to Actions on nodejs/node, except for the Jenkins status updater, which will still need the relay. |
|
Hooray! Cool to see how that in practise made CI-start-on-label in nodejs/node (nodejs/node#34707) a lot simpler as well |
|
I take it back, the new event is still not enough for some use cases (basically any use case that is not a check/linter/test), so we still want the relay |
|
FYI I'll break this into two PRs: one for the Jenkins relay and one for the GitHub relay. Starting with the Jenkins relay which I think is more straightforward. This will allow us to experiment and tweak with it before adding GitHub as well. Also, if it works as expected we'll be able to remove a good chunk of code once we move Jenkins PR status to Actions :D |
|
Good idea! I'm a big fan of ship-small-and-tweak |
mmarchini commentedAug 2, 2020
•
edited
Initial implementation of the "Actions relay" suggested here: #264. Doesn't work yet because createDispatchEvent is not available on the
githubversion we're using.(current PR rebased on top of #271 and #270, actual implementation here)