learn v2 #114

M-ZubairAhmed · 2017-11-29T02:51:46Z

modified learn cards as per design
changed time icon to calendar in events
fluid prop to button added

Under code review
Under design review


        1. modified lean cards

2. changed time icon to calendar in events 3. fluid prop to button added

M-ZubairAhmed · 2017-11-29T02:52:17Z

@saiabhijitht please let me know on the designs of the learn cards while i work on others

coderplex-bot · 2017-11-29T02:52:40Z

Deploy preview ready!

Built with commit a328223

https://deploy-preview-114--coderplex.netlify.com


        Merge branch 'develop' into v2-learn


        tree added


        1. width changes to cards in learn

2. marked js file 3. minor changes in tree comp


        unused prop removed


        functionality of subject page done with out styling


        basic design in place for subjects

abiduzz420 · 2017-12-03T10:42:58Z

components/learn/syllabus-tree/syllabus-tree-container.js

+        ...this.state.nodeStateTracker.slice(0, i),
+        !this.state.nodeStateTracker[i],
+        ...this.state.nodeStateTracker.slice(i + 1),
+      ],


I am curious to know if the implementation I mentioned below is right according to React practices

handleClick = i => { const { nodeStateTracker } = this.state; nodeStateTracker[i] = false; this.forceUpdate() }

Using forceUpdate is often discouraged which can be done with setState instead.
Also state is suppose to be updated with setState . But i havent tried the above code, let me know if its work

Yeah I took the assumption that nodeStateTracker[i] is a child of the state array hence it may not re-render. Hence I did forceUpdate. I kept in my mind that we cannot mutate the state directly though assignment. See if this works and let me know.

abiduzz420 · 2017-12-03T11:01:10Z

components/learn/syllabus-tree/syllabus-tree-component.js

+    let arrowClassName = 'tree-view_arrow';
+    let containerClassName = 'tree-view_children';
+    if (collapsed) {
+      arrowClassName += ' tree-view_arrow-collapsed';


Following ES6 Syntax of concatenating strings

arrowClassName = `${arrowClassName} tree-view_arrow-collapsed`

abiduzz420 · 2017-12-03T11:02:31Z

components/learn/syllabus-tree/syllabus-tree-container.js

+          );
+          return (
+            <TreeView
+              key={i}


Can we assign key={node.unit.name} as in line no 54

@abiduzz420 i am pushing the latest changes. I will go through your review in some time Thank you for reviewing.

Also do you have sometime to work on this pr?

@M-ZubairAhmed No, I may not be able to give time due to exams.


        Merge branch 'develop' into v2-learn


        v changes to table of content


        onhover effects

M-ZubairAhmed · 2017-12-03T12:44:22Z

@vinaypuppal can you help me with the rest of the css implementation of this pr?


        1. many css improvments

2. code base of tree view simplified 3. UI design of tree view complete 4. other minor fixes

M-ZubairAhmed · 2017-12-04T06:48:07Z

@saiabhijitht can you review this and let me know the changes

duttakapil · 2017-12-05T10:45:48Z

"We are constantly updating our platform. Do subscribe to stay informed." should be in 2 lines, split right before Do.

saiabhijitht · 2017-12-05T11:08:26Z

@M-ZubairAhmed
A couple more changes before merging.

Remove the divider line after the Heading "Available Guides".
(It doesn't make sense if we are not having filters.)
Change the text color of Sub-Units in the Table of Contents to #888.

duttakapil · 2017-12-05T11:09:15Z

On /learn page :

Sub-heading should be "To master your favorite technology"


        changes as per #114 (comment)

saiabhijitht · 2017-12-05T11:25:18Z

@aravindballa @buoyantair Thanks for the suggestions. We are not going with the shadows as it does not go with the remaining design as you said.
And the duration being right aligned is good. But courses might be represented in "X days Y hours" or something else in future. Keeping it right aligned would move the icon to a great extent, which would not be preferable. We can think of it later when we have all use cases. I will keep it noted when we redesign the cards for further versions.


        changes as per #114 (comment)


        changes as per #114 (comment)


        Merge branch 'develop' into v2-learn


        font size same as event card

saiabhijitht · 2017-12-05T16:58:13Z

@M-ZubairAhmed
For Mobile version of Subject page,

The Sub-unit title shall be having font-size: 2rem and font-weight: 650


        Merge branch 'v2-learn' of github.com:coderplex/coderplex into v2-learn


        floating syllabus as fab added

duttakapil · 2017-12-11T14:34:41Z

Next upcoming meetup is not showing in the Landing page - Events section
Default image used in the Events section of Landing page should be of higher quality and more relevant
/events page doesn't have the same loading bars as our current live website
Images from meetup.com are not showing on the new /events page anymore


        responsive sidebar

saiabhijitht · 2017-12-11T18:43:09Z

@M-ZubairAhmed
For the mobile version,

place the table of content button in the left-middle of the screen instead of left-top position.
The Sub-unit title shall be having font-size: 2rem and font-weight: 650
see if issue #117 can be solved.


        in response to #114 (comment)


        revert 3212934

1. modified lean cards

Loading status checks…

0d38481

2. changed time icon to calendar in events 3. fluid prop to button added

M-ZubairAhmed added the Status: In Progress label Nov 29, 2017

M-ZubairAhmed requested a review from saiabhijitht Nov 29, 2017

z added 6 commits Nov 29, 2017

Merge branch 'develop' into v2-learn

Loading status checks…

1311d69

tree added

3352b45

1. width changes to cards in learn

7ad04b0

2. marked js file 3. minor changes in tree comp

unused prop removed

Loading status checks…

12cd83c

functionality of subject page done with out styling

Loading status checks…

326de94

basic design in place for subjects

Loading status checks…

981a49b

abiduzz420 reviewed Dec 3, 2017

View changes

Zubair Ahmed added 3 commits Dec 3, 2017

Merge branch 'develop' into v2-learn

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

cbc12e2

v changes to table of content

Loading status checks…

4add6f6

onhover effects

Loading status checks…

a2c032f

M-ZubairAhmed changed the title ~~WIP - learn~~ learn Dec 3, 2017

M-ZubairAhmed changed the title ~~learn~~ learn v2 Dec 3, 2017

M-ZubairAhmed added Type: Bug help-wanted and removed Status: In Progress Type: Bug labels Dec 3, 2017

M-ZubairAhmed added Status: In Progress and removed help-wanted labels Dec 3, 2017

1. many css improvments

Loading status checks…

c06b3b7

2. code base of tree view simplified 3. UI design of tree view complete 4. other minor fixes

M-ZubairAhmed added Status: Awaiting Response and removed Status: In Progress labels Dec 3, 2017

changes as per #114 (comment)

7079186

z added 2 commits Dec 5, 2017

changes as per #114 (comment)

9dd448c

changes as per #114 (comment)

Loading status checks…

4e1e378

M-ZubairAhmed added Status: Awaiting Approval and removed Status: Awaiting Response labels Dec 5, 2017

Merge branch 'develop' into v2-learn

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

9326af1

M-ZubairAhmed added Status: In Progress and removed Status: Awaiting Approval labels Dec 5, 2017

font size same as event card

5b04a75

z added 2 commits Dec 11, 2017

Merge branch 'v2-learn' of github.com:coderplex/coderplex into v2-learn

8d62be9

floating syllabus as fab added

f1440bd

responsive sidebar

Loading status checks…

f7a6619

z added 2 commits Dec 11, 2017

in response to #114 (comment)

Loading status checks…

3212934

revert 3212934

Loading status checks…

a328223

M-ZubairAhmed requested review from saiabhijitht and removed request for vinaypuppal and saiabhijitht Dec 11, 2017

M-ZubairAhmed added Status: Awaiting Approval and removed Status: In Progress labels Dec 11, 2017

saiabhijitht approved these changes Dec 12, 2017

View changes

saiabhijitht merged commit ee16a86 into develop Dec 12, 2017
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

continuous-integration/travis-ci/push The Travis CI build passed
Details

deploy/netlify Deploy preview ready!
Details

saiabhijitht deleted the v2-learn branch Dec 12, 2017

coderplex-org / coderplex

learn v2 #114

learn v2 #114

M-ZubairAhmed commented Nov 29, 2017 •

edited

M-ZubairAhmed commented Nov 29, 2017

coderplex-bot commented Nov 29, 2017 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

M-ZubairAhmed commented Dec 3, 2017

M-ZubairAhmed commented Dec 4, 2017

duttakapil commented Dec 5, 2017 •

edited by M-ZubairAhmed

saiabhijitht commented Dec 5, 2017 •

edited by M-ZubairAhmed

duttakapil commented Dec 5, 2017 •

edited by M-ZubairAhmed

saiabhijitht commented Dec 5, 2017

saiabhijitht commented Dec 5, 2017 •

edited by M-ZubairAhmed

duttakapil commented Dec 11, 2017 •

edited

saiabhijitht commented Dec 11, 2017 •

edited by M-ZubairAhmed

coderplex-org / coderplex

Join GitHub today

learn v2 #114

learn v2 #114

Conversation

M-ZubairAhmed commented Nov 29, 2017 • edited

M-ZubairAhmed commented Nov 29, 2017

coderplex-bot commented Nov 29, 2017 • edited

This comment has been minimized.

abiduzz420 Dec 3, 2017

This comment has been minimized.

M-ZubairAhmed Dec 3, 2017

This comment has been minimized.

abiduzz420 Dec 3, 2017 • edited

This comment has been minimized.

abiduzz420 Dec 3, 2017

This comment has been minimized.

abiduzz420 Dec 3, 2017

This comment has been minimized.

M-ZubairAhmed Dec 3, 2017

This comment has been minimized.

M-ZubairAhmed Dec 3, 2017

This comment has been minimized.

abiduzz420 Dec 3, 2017

M-ZubairAhmed commented Dec 3, 2017

M-ZubairAhmed commented Dec 4, 2017

duttakapil commented Dec 5, 2017 • edited by M-ZubairAhmed

saiabhijitht commented Dec 5, 2017 • edited by M-ZubairAhmed

duttakapil commented Dec 5, 2017 • edited by M-ZubairAhmed

saiabhijitht commented Dec 5, 2017

saiabhijitht commented Dec 5, 2017 • edited by M-ZubairAhmed

duttakapil commented Dec 11, 2017 • edited

saiabhijitht commented Dec 11, 2017 • edited by M-ZubairAhmed

M-ZubairAhmed commented Nov 29, 2017 •

edited

coderplex-bot commented Nov 29, 2017 •

edited

abiduzz420 Dec 3, 2017 •

edited

duttakapil commented Dec 5, 2017 •

edited by M-ZubairAhmed

saiabhijitht commented Dec 5, 2017 •

edited by M-ZubairAhmed

duttakapil commented Dec 5, 2017 •

edited by M-ZubairAhmed

saiabhijitht commented Dec 5, 2017 •

edited by M-ZubairAhmed

duttakapil commented Dec 11, 2017 •

edited

saiabhijitht commented Dec 11, 2017 •

edited by M-ZubairAhmed