Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplemented .pop() method for list #126
Open
Conversation
|
@xarus01 CI is failed. Please take a look |
|
Here is the failure. This is trying to run the tests under python3.4. (there was more stuff I've snipped out the error which seems to be python trying to report errors via apport and failing |
| assert a.pop() == 1 | ||
| assert a.pop(2) == 4 |
Comment on lines
+40
to
+41
This comment has been minimized.
This comment has been minimized.
tim-st
Dec 1, 2019
•
Contributor
The pop operation removes and returns from the back, I think your idea was removing from the front.
It would be good if you create a new list for each test and compare your test against a list like assert a.pop(-1) == element; assert a = [...], that makes it more clear here.
Additionally the following tests would be good:
- negative index
- index out of range for non-empty list
- parameter of wrong type (non-int)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
xarus01 commentedNov 6, 2019
•
edited by sbinet
Fixes #95.