Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: set up ts-circular-deps check to prevent new circular deps #17287
+16
−2
Conversation
|
There's a tslint rule in place that checks for circular imports: https://github.com/angular/angular-cli/blob/master/tslint.json#L6 |
|
@josephperrott should this be closed? Since we are handling circular deps with tslint? |
efd804e
to
b654193
b654193
to
1ded4e8
|
@alan-agius4 and I spoke offline, and I believe its still an open question of if this should be added/included. My main concern is that we prevent circular deps, which is already being done in this repository. The argument for merging this in is to have the same method for circular deps discovery/enforcement used across our org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The repo current has zero circular typescript dependencies, this check will ensure no circular dependencies are added.