Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdbinit: Use proper define syntax #19557

Merged
merged 1 commit into from Apr 23, 2020
Merged

gdbinit: Use proper define syntax #19557

merged 1 commit into from Apr 23, 2020

Conversation

The-Compiler
Copy link
Contributor

@The-Compiler The-Compiler commented Apr 16, 2020 •
edited by miss-islington

Using def rather than define results in:

Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella

@The-Compiler
gdbinit: Use proper define syntax
5857556 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.
@csabella csabella added skip issue skip news needs backport to 3.7 needs backport to 3.8 🤖 automerge labels Apr 23, 2020
csabella
csabella approved these changes Apr 23, 2020
View changes
Copy link
Contributor

@csabella csabella left a comment

lgtm

@miss-islington miss-islington merged commit 1221135 into python:master Apr 23, 2020
5 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 23, 2020

Thanks @The-Compiler for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 23, 2020
@The-Compiler @miss-islington
gdbinit: Use proper define syntax (pythonGH-19557)
47669da 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella
(cherry picked from commit 1221135)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 23, 2020

GH-19676 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 23, 2020

Sorry, @The-Compiler, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1221135289306333d11db25ab20cbbd21ceec630 3.7

@miss-islington miss-islington self-assigned this Apr 23, 2020
miss-islington added a commit that referenced this issue Apr 23, 2020
@miss-islington @The-Compiler
gdbinit: Use proper define syntax (GH-19557)
714aa83 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella
(cherry picked from commit 1221135)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@The-Compiler
Copy link
Contributor Author

@The-Compiler The-Compiler commented Apr 23, 2020 •
edited

Manual cherry-pick to 3.7: #19678

edit: Hah, faster than the bot 😉

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 23, 2020

GH-19678 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit that referenced this issue Apr 23, 2020
@The-Compiler
[3.7] gdbinit: Use proper define syntax (GH-19557) (GH-19678)
e1072d6 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella.
(cherry picked from commit 1221135)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
vegerot pushed a commit to vegerot/cpython that referenced this issue Jun 10, 2020
@The-Compiler @vegerot
gdbinit: Use proper define syntax (pythonGH-19557)
050b4cb 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella
vegerot pushed a commit to vegerot/cpython that referenced this issue Jun 10, 2020
@The-Compiler @vegerot
gdbinit: Use proper define syntax (pythonGH-19557)
45d5000 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella
gmelikov pushed a commit to gmelikov/cpython that referenced this issue Aug 22, 2020
@The-Compiler @gmelikov
gdbinit: Use proper define syntax (pythonGH-19557)
0841d2f 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella
chrisburr pushed a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
@The-Compiler @chrisburr
gdbinit: Use proper define syntax (pythonGH-19557)
a227f61 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

Assignees

@miss-islington miss-islington

Labels
CLA signed 🤖 automerge skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@The-Compiler @miss-islington @bedevere-bot @csabella @the-knights-who-say-ni