Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync with upstream @ 58f6599d #34
Merged
Conversation
My proposed change may not be right, but "make a request to URL" was unclear, and it's `fetch` that's used below to make the request. If 'request to URL' has some special meaning and is what you want to say, maybe some rephrasing is in order.
Confucius never said anything about black cat Ref: https://www.washingtonpost.com/world/2019/03/25/chinese-proverb-that-russia-cited-respond-mueller-report-does-not-appear-be-chinese-proverb/
"// obj.toString === obj.__proto__.toString == Object.prototype.toString" It is look like JS code but it gives different result from what we want to get. There is different kind of equality operator ant these give more confusing what is the purpose of these? It can be better to separate this line into 2 line of code to make it sensible and readable. Subject and code is already hard but there is no need to make readers ask unnecessary questions.
An interesting question may arise in the example above: what’s the value of this inside set fullName(value)? Where are the properties this.name and this.surname written: into user or admin? The answer is simple: this is not affected by prototypes at all. No matter where the method is found: in an object or its prototype. In a method call, this is always the object before the dot. So, the setter call admin.fullName= uses admin as this, not user. That is actually a super-important thing, because we may have a big object with many methods, and have objects that inherit from it. And when the inheriting objects run the inherited methods, they will modify only their own states, not the state of the big object. The example code doesn't show these concepts. Also, these additions can make readers ask questions before the explanation of the example code.
Small fixes.
Added link to Brython Python transpiler to JavaScript
add semicolon 13,20 line
Explained how to create a date object.
add missing closing bracket
Update article.md
Typo
Typos
Typos
fix typo and minor grammatical error
…stion suggestion to use alert method not console.log
The last 2 code snippets shouldn't be runnable
misplaced "too"?
Update article.md
Confucius never said black cat quote
Delete a blank
One line of code creates a lot of confusing
typo
CLAassistant
commented
Sep 7, 2020
•
|
Aiyo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
There is a conflict in one file. I will resolve the conflict and merge it by tomorrow. |
|
Accepting the MR. merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
javascript-translate-bot commentedSep 7, 2020
This PR was automatically generated to merge changes from en.javascript.info at 58f6599
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterThis PR will be closed and replaced with a new one in a few days.