Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd javadoc and inline comments to HashMap.java #1395
Conversation
|
You may have to re-pull because upstream master HashMap.java just got updated |
|
Hi @rbshealy please review this Thanks |
| public int hashing(int key) { | ||
| int hash = key % hsize; | ||
| if (hash < 0) | ||
| hash += hsize; | ||
| return hash; | ||
| } | ||
|
|
Comment on lines
16
to
22
|
Hi @rbshealy I have an updated |
|
Looks great! The only thing left is to un-delete the hashing method |
|
Hi @rbshealy i've done un-delete hashing method |
|
great work! This addresses the issue pretty well 👍🏻 |
|
Hi @StepfenShawn could you please review then merge this if necessary? |
|
|
||
| /** | ||
| * Get the next node after the current node | ||
| * @return Node next node | ||
| */ |
Comment on lines
+213
to
+217
rbshealy
Aug 16, 2020
•
Contributor
Before this gets merged, I just re-checked it and found some indentation errors, can you fix these? I will approve all changes after you do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I added a javadoc comment and made a little change to the modifier method
closes #1394