Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file-transfer: writing tests and ensuring that all is going well #2413

Merged
merged 5 commits into from Sep 11, 2020
Merged

file-transfer: writing tests and ensuring that all is going well #2413

merged 5 commits into from Sep 11, 2020
+40 −10

Conversation

@meysam81
Copy link
Contributor

meysam81 commented Sep 10, 2020

Describe your change:

I added tests for improving coverage as mentioned in #2128

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@meysam81
file-transfer: writing tests and ensuring that all is going well
Loading status checks…
4bbbbca
@cclauss
cclauss reviewed Sep 10, 2020
View changes
file_transfer/send_file.py Outdated Show resolved Hide resolved
cclauss added 2 commits Sep 11, 2020
@cclauss
def send_file(filename: str = "mytext.txt", testing: bool = False) ->…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
92b3d0b 
… None:
@cclauss
send_file(filename="mytext.txt", testing=True)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3f49ad5
@TravisBuddy
Copy link

TravisBuddy commented Sep 11, 2020

Hey @meysam81,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7f43b680-f470-11ea-a882-ef0b60d9fbb3
@TravisBuddy
Copy link

TravisBuddy commented Sep 11, 2020

Hey @meysam81,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ddb088b0-f470-11ea-a882-ef0b60d9fbb3
@cclauss
Update send_file.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
223fd19
@TravisBuddy
Copy link

TravisBuddy commented Sep 11, 2020

Travis tests have failed

Hey @meysam81,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 03d7b9e0-f472-11ea-a882-ef0b60d9fbb3
@cclauss
requirements.txt: lxml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1b75a5b
@cclauss
cclauss approved these changes Sep 11, 2020
View changes
Copy link
Member

cclauss left a comment

A nice example of how to mock and test communications code.
@cclauss cclauss merged commit 2e790ce into TheAlgorithms:master Sep 11, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
@meysam81 meysam81 deleted the meysam81:test/send-file branch Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@meysam81 @TravisBuddy @cclauss
You can’t perform that action at this time.