Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type hints and doctests to arithmetic_analysis/newton_method.py #2258

Closed
wants to merge 1 commit into from
Closed

added type hints and doctests to arithmetic_analysis/newton_method.py #2258

wants to merge 1 commit into from

Conversation

@spamegg1
Copy link
Contributor

spamegg1 commented Aug 1, 2020

continuing #2128
Also changed some variable names, made them more descriptive.

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
@spamegg1
added type hints and doctests to arithmetic_analysis/newton_method.py
Loading status checks…
ddade5b 
continuing #2128
Also changed some variable names, made them more descriptive.
@TravisBuddy
Copy link

TravisBuddy commented Aug 1, 2020

Hey @spamegg1,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1e264650-d3ce-11ea-9b7b-6b7bbdba586d
@spamegg1
Copy link
Contributor Author

spamegg1 commented Aug 1, 2020

Very strange, Travis complains that math is unused, because it's only used inside doctests! So I should only import math inside the doctests then?
@spamegg1 spamegg1 closed this Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@spamegg1 @TravisBuddy
You can’t perform that action at this time.