Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39651: Fix asyncio proactor _write_to_self() #22197

Merged
merged 1 commit into from Sep 12, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 11, 2020

Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.

https://bugs.python.org/issue39651

Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
@vstinner
Copy link
Member Author

vstinner commented Sep 11, 2020

@1st1 @asvetlov: Would you mind to review my change?

I didn't test my patch, I basically copied/pasted the code between SelectorEventLoop to ProactorEventLoop.

1st1
1st1 approved these changes Sep 11, 2020
@1st1
Copy link
Member

1st1 commented Sep 11, 2020

looks ok to me

@vstinner vstinner merged commit 1b0f0e3 into python:master Sep 12, 2020
3 checks passed
@vstinner vstinner deleted the asyncio_write_to_self branch Sep 12, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Sep 12, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 12, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
(cherry picked from commit 1b0f0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Sep 12, 2020

GH-22215 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
(cherry picked from commit 1b0f0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Sep 12, 2020

GH-22216 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
(cherry picked from commit 1b0f0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Sep 12, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
(cherry picked from commit 1b0f0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants