Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
bpo-38101: Update devguide triaging keywords #570
Conversation
|
@taleinat I wasn't sure how to find a reviewer for this/the reviewer in the issue from Sept. |
| @@ -375,6 +375,13 @@ Various informational flags about the issue. Multiple values are possible. | |||
| | easy | Fixing the issue should not take longer than a day for | | |||
| | | someone new to contributing to Python to solve. | | |||
| +---------------+------------------------------------------------------------+ | |||
| | easy (C) | Fixing the issue should not take longer than a day for | | |||
| | | someone new contributing to Python, focused on C/C++. | | |||
| +---------------+------------------------------------------------------------+ | ||
| | security_issue| The issue would fit as, or is related as a security issue. | | ||
| +---------------+------------------------------------------------------------+ | ||
| | PEP 3121 | The issue fit as, or is related to the PEP 3123 module | |
taleinat
Feb 3, 2020
Contributor
The PEP number here is off, it should be 3121. Also, a few words about the subject of the PEP, and a link to it, would be very helpful.
|
I have made the requested changes; please review again |
|
Looking good, almost there! One more comment. |
| | PEP 3121 | The issue fit as, or is related to the PEP 3121 module | | ||
| | | Which is the Extension Module Initialization and | | ||
| | | Finalization, For More information: | | ||
| | | https://www.python.org/dev/peps/pep-3121/ | |
taleinat
Feb 12, 2020
Contributor
The wording and capitalization here are a bit clumsy. My suggestion:
"The issue is related to `PEP 3121`_: Extension Module Initialization and Finalization."
(The above assumes adding the link for PEP 3121 below it.)
|
I have made the requested changes; please review again |
| | easy (C) | Fixing the issue should not take longer than a day for | | ||
| | | someone new contributing to Python, focused on C. | | ||
| +---------------+------------------------------------------------------------+ | ||
| | security_issue| The issue would fit as, or is related as a security issue. | |
taleinat
Feb 13, 2020
Contributor
| | security_issue| The issue would fit as, or is related as a security issue. | | |
| | security_issue| This is a security issue or is related to one. | |
| | | someone new contributing to Python, focused on C. | | ||
| +---------------+------------------------------------------------------------+ | ||
| | security_issue| The issue would fit as, or is related as a security issue. | | ||
| | | The main difference from "security" is that this is a | |
taleinat
Feb 13, 2020
Contributor
"security" is out of context here, so maybe write something "The main difference from the "secutiry" issue type is..."
idomic
Feb 14, 2020
Author
Contributor
Added both changes, I think also since there is no security keyword in the bug tracker, the main difference is that is a definite problem right? While the security type above it is more for reporting a possible issue.
|
I have made the requested changes; please review again |
|
@taleinat I think the link to pep 3121 is failing the CI, any way to override it? |
|
@idomic, the CI is failing correctly! The build fails because you haven't defined where the "PEP 3121" link should point to. It needs to be like this: This is a paragraph that contains `a link`_.
.. _a link: https://domain.invalid/For more info, check out similar links in this (or other ReST) documents, or the ReST Primer. |
|
Ok, after lots of commits (sorry haha), that's ready CI is passing. |
|
LGTM |
|
Thanks for taking this up and following through, @idomic! |
Added 3 new keywords: pep 3121, security_issue, easy (C)