Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: let library to support “@” #17690

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@Eusen
Copy link
Contributor

@Eusen Eusen commented May 11, 2020

When I execute ng g application @apps/app1, I get the following results:

- @app/
-       app1/
(newProjectRoot = "")

But !!! When I execute ng g library @libs/lib1, I got the result:

- libs/
-      lib1/

This is too awkward !!!

Please! Remove the .replace(/^@/, '') here, or add the .replace(/^@/, '') to the application!

I think it's really weird now...

When I execute `ng g application @apps/app1`, I get the following results:
``` text
- @app/
-       app1/
(newProjectRoot = "")
```

But !!! When I execute `ng g library @libs/lib1`, I got the result:
``` text
- libs/
-      lib1/
```

This is too awkward !!!

Please! Remove the `.replace(/^@/, '')` here, or add the `.replace(/^@/, '')` to the application!

I think it's really weird now...
@googlebot googlebot added the cla: yes label May 11, 2020
@Eusen Eusen changed the title Support library to have @ flag refactor: let library to support “@” May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.