Skip to content

/ github

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Cannot read property 'encode' of undefined during executing writeFile() #456

Open
wants to merge 1 commit into
base: master
from
Open

Fixed: Cannot read property 'encode' of undefined during executing writeFile() #456

wants to merge 1 commit into from
+1 −0

Conversation

@makishvili
Copy link

makishvili commented Jun 16, 2017 •
edited

I am trying to execute writeFile without optional options-parameter.
repo.writeFile('master', 'file.txt', 'some text', some message');

But getting the error:

~project/node_modules/github-api/dist/components/Repository.js:912
         var shouldEncode = options.encode !== false;
                                   ^

TypeError: Cannot read property 'encode' of undefined
    at Repository.writeFile (~project/node_modules/github-api/dist/components/Repository.js:912:36)
    at Object.<anonymous> (~project/gist.js:13:6)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
@makishvili
Fixed: Cannot read property 'encode' of undefined during executing wr…
Loading status checks…
990e03e 
…iteFile()
@j-rewerts
j-rewerts requested changes Apr 7, 2019
View changes
Copy link
Member

j-rewerts left a comment

@makishvili Could you add a test showing the situation you've described? I'd like to see a test pass that wouldn't have passed before.
@hazmah0 hazmah0 mentioned this pull request Sep 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rewerts j-rewerts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@makishvili @j-rewerts
You can’t perform that action at this time.