Skip to content

/ github

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(repository): fixes linting errors #597

Open
wants to merge 1 commit into
base: master
from
Open

test(repository): fixes linting errors #597

wants to merge 1 commit into from
+1 −1

Conversation

@hazmah0
Copy link
Contributor

hazmah0 commented Nov 4, 2019

Fixes that lint task is failing in CI since merging #588
@hazmah0
test(repository): fixes linting errors
bc36194
@jasonhaxstuff
jasonhaxstuff approved these changes Jan 5, 2020
View changes
Copy link

jasonhaxstuff left a comment

A failing test doesn't look too good and hinders PR compatibility checks.
@DanielRuf
Copy link

DanielRuf commented Jan 5, 2020

@jasonhaxstuff not sure what you mean, mistakes happen.
@jasonhaxstuff
Copy link

jasonhaxstuff commented Jan 5, 2020 •
edited

@DanielRuf I was stating a reason of approval. Pretend like I prefaced my comment with "I'm approving this because...".
@DanielRuf
DanielRuf approved these changes Jan 5, 2020
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf

@jasonhaxstuff jasonhaxstuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@hazmah0 @DanielRuf @jasonhaxstuff
You can’t perform that action at this time.