Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(@ngtools/webpack): add Webpack 5 to peer dependencies #18847
+2
−2
Conversation
e99fc4d
to
6d8d63d
| @@ -28,7 +28,7 @@ | |||
| "peerDependencies": { | |||
| "@angular/compiler-cli": "^11.0.0 || ^11.0.0-next", | |||
| "typescript": ">=3.9 < 4.1", | |||
| "webpack": "^4.0.0" | |||
| "webpack": "^4.0.0 || ^5.0.0" | |||
alan-agius4
Sep 22, 2020
Collaborator
Webpack version 5 is not yet stable thus the semver version here is invalid. It should be ^5.0.0-rc.0.
Chiming in @clydin just to confirm whether we should add this peerDependencies in the first place since Webpack 5 support is still experimental, and adding Webpack 5 might send out the wrong message.
alan-agius4
Sep 22, 2020
Collaborator
PS: chore is an invalid commit message type. You can use fix for this.
fix(@ngtools/webpack): add Webpack 5 to peer dependencies
valorkin
Sep 22, 2020
Author
Contributor
I know, just made it the same way as it appears in all other occurrences. I can change those to rc.0 too
6d8d63d
to
665e999
665e999
to
878ebc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Very minor addition to #18820
adding optional webpack@5 to peer dependencies of ngtools/webpack