Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded NullHandlers to all loggers to prevent "No handler" messages #300
Conversation
When the code is run without setting up loggers, the loggers have no handlers for the emitted messages. The logging module displays: `No handlers could be found for logger "git.cmd"` on the console. By adding a NullHandler (a no-op) the message disappears, and doesn't affect logging when other handlers are configured.
|
So I see the CI build ran with Python 2.6. Is there a list of supported Python versions? I can add a NullHandler as described here, but I'm not sure whre you would want that to live: https://docs.python.org/release/2.6/library/logging.html#configuring-logging-for-a-library Edit: Looks like more stuff failed. I'm working on that too. Also noticed the CI process lists the versions it tests against. |
|
I'm not able to reproduce the error on my machine in Python 2.7. Also on the CI build, 'FOO' is totally in the exception. I'm not really sure what's supposed to be going on:
|
aa0ccea
into
gitpython-developers:master
|
Thanks a for your contribution! I took the liberty to add the required NullHandler implementation myself. Besides, you are right, the |
|
You can watch the development stream on youtube.
|
When the code is run without setting up loggers, the loggers have no
handlers for the emitted messages. The logging module displays:
No handlers could be found for logger "git.cmd"on theconsole. By adding a NullHandler (a no-op) the message disappears,
and doesn't affect logging when other handlers are configured.