Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDefine PermissionError in Python versions < 3.3 #830
Closed
Conversation
Simplify by defining [__PermissionError__](https://docs.python.org/3/library/exceptions.html#PermissionError) in Python 2 in alignment with Python porting best practice [___use feature detection instead of version detection___](https://docs.python.org/3/howto/pyporting.html#use-feature-detection-instead-of-version-detection).
jeking3
added a commit
to jeking3/GitPython
that referenced
this pull request
Jan 24, 2019
This closes gitpython-developers#830
|
Closing in favor of #826. |
jeking3
added a commit
to jeking3/GitPython
that referenced
this pull request
Feb 6, 2019
This closes gitpython-developers#830
jeking3
added a commit
to jeking3/GitPython
that referenced
this pull request
Mar 15, 2019
This closes gitpython-developers#830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Simplify the logic by defining PermissionError in Python 2 in alignment with Python porting best practice use feature detection instead of version detection.