Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created problem_112.py in project_euler #2532

Merged
merged 12 commits into from Oct 3, 2020
Merged

Created problem_112.py in project_euler #2532

merged 12 commits into from Oct 3, 2020
+89 −0

Conversation

@Kush1101
Copy link
Member

@Kush1101 Kush1101 commented Sep 30, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Kush1101 added 3 commits Sep 30, 2020
@Kush1101
Add files via upload
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
42b233e
@Kush1101
Create __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8e80876
@Kush1101
Update and rename project_euler/problem_112.py to project_euler/probl…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd8780c 
…em_112/sol1.py
@Kush1101
Copy link
Member Author

@Kush1101 Kush1101 commented Oct 1, 2020

@shellhub, @dhruvmanila would be interested in reviewing this?
@dhruvmanila
dhruvmanila reviewed Oct 1, 2020
View changes
project_euler/problem_112/sol1.py Outdated Show resolved Hide resolved
@Kush1101 @dhruvmanila
Update project_euler/problem_112/sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6b5bec1 
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
@dhruvmanila
dhruvmanila reviewed Oct 1, 2020
View changes
project_euler/problem_112/sol1.py Outdated Show resolved Hide resolved
@dhruvmanila
dhruvmanila reviewed Oct 1, 2020
View changes
project_euler/problem_112/sol1.py Show resolved Hide resolved
Kush1101 added 2 commits Oct 1, 2020
@Kush1101
Update sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c1b8ccd
@Kush1101
Update sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1635a7f
@shellhub
shellhub requested changes Oct 1, 2020
View changes
project_euler/problem_112/sol1.py Show resolved Hide resolved
project_euler/problem_112/sol1.py Show resolved Hide resolved
@TheAlgorithms TheAlgorithms deleted a comment from dhruvmanila Oct 1, 2020
@shellhub
shellhub requested changes Oct 1, 2020
View changes
project_euler/problem_112/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_112/sol1.py Show resolved Hide resolved
@Kush1101 @shellhub
Update project_euler/problem_112/sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
00923f6 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@shellhub
Copy link
Member

@shellhub shellhub commented Oct 1, 2020

@Kush1101
Copy link
Member Author

@Kush1101 Kush1101 commented Oct 1, 2020 •
edited

But you can have float percentages as well. Testing it for 99.2 or 99.3 will not yield results if we have ==
@shellhub
shellhub reviewed Oct 1, 2020
View changes
project_euler/problem_112/__init__.py Outdated Show resolved Hide resolved
Kush1101 and others added 2 commits Oct 1, 2020
@Kush1101 @shellhub
Update project_euler/problem_112/__init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7323ce7 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@Kush1101
Update __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8fcdcc8
@Kush1101
Copy link
Member Author

@Kush1101 Kush1101 commented Oct 1, 2020

I think it can be merged now.
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 2, 2020

@Kush1101 Do you mean that if we keep the __init__.py file empty the tests are failing?
Can you point out which tests are failing?
@Kush1101
Copy link
Member Author

@Kush1101 Kush1101 commented Oct 2, 2020

@Kush1101 Do you mean that if we keep the __init__.py file empty the tests are failing?
Can you point out which tests are failing?

Travis CI tests.
@Kush1101
Copy link
Member Author

@Kush1101 Kush1101 commented Oct 2, 2020

@cclauss I think it's up to you now. Can you review it?
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 2, 2020

I don't think so because almost all the __init__.py files are empty. Can you provide me the link for the build which failed due to this issue? That would be really helpful in finding out what's going on. Thanks.
@Kush1101
Update __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dde4b3f
@Kush1101
Copy link
Member Author

@Kush1101 Kush1101 commented Oct 2, 2020 •
edited

I don't think so because almost all the __init__.py files are empty. Can you provide me the link for the build which failed due to this issue? That would be really helpful in finding out what's going on. Thanks.
You can see it now. It's actually the pre-commit test that fails.
@shellhub
shellhub reviewed Oct 2, 2020
View changes
Copy link
Member

@shellhub shellhub left a comment

delete empty line. and try it.
project_euler/problem_112/__init__.py Outdated Show resolved Hide resolved
@Kush1101
Update __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bc220c7
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 3, 2020

Merging is blocked as @shellhub requested some changes. Maybe only he can merge this?
@shellhub
delete __init__.py content
Loading status checks…
b4f2f0e
@shellhub
shellhub approved these changes Oct 3, 2020
View changes
Copy link
Member

@shellhub shellhub left a comment

LGTM.
@shellhub shellhub merged commit 6a39545 into TheAlgorithms:master Oct 3, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

@shellhub shellhub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Kush1101 @shellhub @dhruvmanila
You can’t perform that action at this time.