Skip to content

/ gatsby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-plugin-mdx): run prettier #16575

Merged
merged 6 commits into from Aug 13, 2019
Merged

chore(gatsby-plugin-mdx): run prettier #16575

merged 6 commits into from Aug 13, 2019

Conversation

@mathieudutour
Copy link
Collaborator

@mathieudutour mathieudutour commented Aug 13, 2019

Description

gatsby-plugin-mdx was ignored by prettier and eslint. This PR fixes it and lint the plugin.
@mathieudutour
run prettier on gatsby-plugin-mdx
Loading status checks…
30a0252
@mathieudutour mathieudutour requested review from gatsbyjs/core as code owners Aug 13, 2019
@pieh pieh added the topic: MDX label Aug 13, 2019
@sidharthachatterjee
sidharthachatterjee requested changes Aug 13, 2019
View changes
Copy link
Member

@sidharthachatterjee sidharthachatterjee left a comment

Thanks!

Left a small suggestion
.prettierignore Outdated Show resolved Hide resolved
@sidharthachatterjee
Update .prettierignore
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dbe9f8b
@sidharthachatterjee
sidharthachatterjee reviewed Aug 13, 2019
View changes
@sidharthachatterjee sidharthachatterjee changed the title [chore] run prettier on gatsby-plugin-mdx chore(gatsby-plugin-mdx): run prettier Aug 13, 2019
@mathieudutour
Merge branch 'master' into f/lint-gatsby-plugin-mdx
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91bdbda
@mathieudutour
fix lint
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
87de3f4
@mathieudutour
fix lint
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8a3fa72
@mathieudutour
fix lint
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3f9c6f0
@sidharthachatterjee
sidharthachatterjee approved these changes Aug 13, 2019
View changes
Copy link
Member

@sidharthachatterjee sidharthachatterjee left a comment

👍
@gatsbybot gatsbybot merged commit 43f29d9 into master Aug 13, 2019
19 checks passed
19 checks passed
Danger All good
Details
Peril All green. Good on 'ya.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
cypress: default-group 67 tests passed in 00:37
Details
unit_tests_windows Build #20190813.58 succeeded
Details
@sidharthachatterjee sidharthachatterjee deleted the f/lint-gatsby-plugin-mdx branch Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee

Assignees
No one assigned
Labels
bot: merge on green topic: MDX
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mathieudutour @sidharthachatterjee @pieh @gatsbybot
You can’t perform that action at this time.