Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #2378

Merged
merged 6 commits into from Aug 31, 2020
Merged

Update CONTRIBUTING.md #2378

merged 6 commits into from Aug 31, 2020

Conversation

@muskanvk
Copy link
Contributor

@muskanvk muskanvk commented Aug 31, 2020 •
edited

  1. fixed dead link to the license in CONTRIBUTING.md file
  2. Added the MIT License to README.md file
  • Add an algorithm?
  • [Y ] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ Y] I have read CONTRIBUTING.md.
  • [Y ] This pull request is all my own work -- I have not plagiarized.
  • [Y ] I know that pull requests will not be merged if they fail the automated tests.
  • [Y ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [Y ] All new Python files are placed inside an existing directory.
  • [Y ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ Y] All functions and variable names follow Python naming conventions.
  • [ Y] All function parameters and return values are annotated with Python type hints.
  • [ Y] All functions have doctests that pass the automated testing.
  • [Y ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ Y] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@muskanvk
Update CONTRIBUTING.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f3935bf 
fixed dead link to the license
@muskanvk muskanvk mentioned this pull request Aug 31, 2020
Closed
muskanvk added 2 commits Aug 31, 2020
@muskanvk
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0280fe3 
Added License
@muskanvk
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2d6e111
@cclauss
cclauss reviewed Aug 31, 2020
View changes
README.md Outdated
@@ -1,5 +1,6 @@
# The Algorithms - Python
[![Gitpod Ready-to-Code](https://img.shields.io/badge/Gitpod-Ready--to--Code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/TheAlgorithms/Python)
[![Gitpod Ready-to-Code](https://img.shields.io/badge/Gitpod-Ready--to--Code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/TheAlgorithms/Python)
![](https://img.shields.io/github/license/sourcerer-io/hall-of-fame.svg?colorB=ff0000)

This comment has been minimized.

Sign in to view
@cclauss

cclauss Aug 31, 2020
Member

What is this?

This comment has been minimized.

Sign in to view
@muskanvk

muskanvk Aug 31, 2020
Author Contributor

This is the license shield (MIT License) that I have added
cclauss added 3 commits Aug 31, 2020
@cclauss
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a756c42
@cclauss
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5ed2151
@cclauss
Update CONTRIBUTING.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cffecef
@cclauss
cclauss approved these changes Aug 31, 2020
View changes
@cclauss cclauss merged commit e92e433 into TheAlgorithms:master Aug 31, 2020
1 of 2 checks passed
1 of 2 checks passed
codespell
Details
Travis CI - Pull Request Build Errored
Details
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Aug 31, 2020

Hey @muskanvk,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 26414a50-ebc1-11ea-95c6-05b7905ca42d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@muskanvk @TravisBuddy @cclauss
You can’t perform that action at this time.