bpo-41428: Documentation for PEP 604 #22517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamanu
reviewed
Oct 3, 2020
|
@MaggieMoss Do you have time to you review this? It's about your code. :-) |
pablogsal
reviewed
Oct 3, 2020
gvanrossum
reviewed
Oct 3, 2020
Misc/NEWS.d/next/Documentation/2020-10-03-18-20-46.bpo-41428._ju1NE.rst
Outdated
Show resolved
Hide resolved
|
@gvanrossum and @pablogsal , thanks for the extremely thorough review. I implemented the suggested changes. |
|
Thanks guido, pablo and eamanu for the patience and guidance for this PR. This was my first time writing reST/writing docs for CPython for that matter, and it was extremely fun! The devguide was extremely helpful too :). |
|
@Fidget-Spinner You did a great job. Do you want to help more? |
|
@gvanrossum Yea definitely, I'll work on something else when I have the time to do so ! |
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Added documentation for PEP 604.
https://bugs.python.org/issue41428