Skip to content

Typo fix#22496

Merged
miss-islington merged 2 commits intopython:masterfrom
MananKGarg:typo-fix
Oct 4, 2020
Merged

Typo fix#22496
miss-islington merged 2 commits intopython:masterfrom
MananKGarg:typo-fix

Conversation

@MananKGarg
Copy link
Contributor

@MananKGarg MananKGarg commented Oct 2, 2020 •
edited by miss-islington
Loading

Multiple typo fixes in code comments

Automerge-Triggered-By: @Mariatta

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Oct 2, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@MananKGarg

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@MananKGarg
Multiple typo fixes
5d0838c 
Multiple typo fixes in comments
Mariatta
Mariatta approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@miss-islington miss-islington merged commit 619f980 into python:master Oct 4, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Oct 4, 2020

Thanks @MananKGarg for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2020
@MananKGarg @miss-islington
Typo fix (pythonGH-22496)
19d6010 
Multiple typo fixes in code comments

Automerge-Triggered-By: @Mariatta
(cherry picked from commit 619f980)

Co-authored-by: Manan Kumar Garg <62146744+MananKGarg@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 4, 2020

GH-22548 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 4, 2020

Thanks @MananKGarg for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 4, 2020

Sorry, @MananKGarg, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 619f98045d73859688e5cfdb946d183e6d493a64 3.8

@miss-islington miss-islington self-assigned this Oct 4, 2020
miss-islington added a commit that referenced this pull request Oct 4, 2020
@miss-islington @MananKGarg
Typo fix (GH-22496)
f3a6b7f 
Multiple typo fixes in code comments

Automerge-Triggered-By: @Mariatta
(cherry picked from commit 619f980)

Co-authored-by: Manan Kumar Garg <62146744+MananKGarg@users.noreply.github.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@MananKGarg
Typo fix (pythonGH-22496)
a937b4c 
Multiple typo fixes in code comments

Automerge-Triggered-By: @Mariatta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees

@miss-islington miss-islington

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MananKGarg @the-knights-who-say-ni @miss-islington @bedevere-bot @iritkatriel @Mariatta